Feature Proposal: Get rid SEARCHDEFAULTTTYPE

---

Motivation

SEARCHDEFAULTTTYPE:

• has been misspelt for years
• isn't unit tested
• duplicates some code
• can be done with url parameters to the WebSearch script
• and most probably, is never used.

Therefore, instead of fixing the typo (an extra T), just remove the feature entirely.

---

Description and Documentation

We need to do something with this typo. Either we fix the typo as (tw)wiki did (See TWikibug:Item6217), and we might loose the few people who used this feature, or we keep both for compatibility, or we remove this.

---

Examples

---

Impact

WhatDoesItAffect:

%WHATDOESITAFFECT%

edit

---

Implementation

-- Contributors: OlivierRaginel - 25 Mar 2009

---

Discussion

I would not remove it.

I have been thinking about this one since I closed Tasks.Item1354

I plan to reopen it and fix the spelling AND do some adjustments to the defaults.

We do not want the default from DefaultPreferences to be used in WebSearch. We had a long discussion back in 2007 about this in the old project and we reached a good concensus of what we wanted and this was all implemented. Except for the search script and the preference topic.

I will gladly take on the task to fix this one so it matches the decisions we made and in combination both fixes the spelling and without doing the destruction and non-compatible fix the other project did.

-- KennethLavrsen - 25 Mar 2009

imo the search script is an unmaintained duplication of functionality, and this very long standing spelling mistake shows both how little use it gets, and how little dev and testing attention it receives. In light of resource realities, I would suggest removing it altogether.

-- SvenDowideit - 25 Mar 2009

plugging Olivier and Kenneth in as committed developers - please park it if you don't just doit

-- SvenDowideit - 06 Mar 2010

Suggestion:

1. Remove SEARCHDEFAULTTTYPE from DefaultPreferences and documentation
2. When performing search do these steps (they are probably already in the code):
   • Use the type parameter
   • If not set, use SEARCHDEFAULTTTYPE (legacy behaviour)
   • If not set, use keyword

-- ArthurClemens - 06 Mar 2010

What is proposed here? I see Arthur's clear statement as one proposal, Olivier's original proposal (also clear) as another. Sven is proposing something apparently unrelated (removal of the =search- script) and Kenneth is proposing "some adjustments" and pointing to a bug item where he has made comments that seem to directly contradict what he says above. Any chance of a bit of consensus, please?

Concern raised cos I can't work out what's happening.

-- CrawfordCurrie - 09 Mar 2010

There are 100 more important things to do than this.

I park it for now

-- KennethLavrsen - 24 Mar 2010