Item10163: Nested groups expand with LdapUserMapping enabled, breaking groups UI

As you can see in Tasks.Item9810, the groups management UI should no longer expand groups when they are nested within another group. This is so that the newly re-written UI can treat nested groups as single entities for the prurposes of adding and removing them as group members.

Setting UserMappingManager to LdapUserMapping seems to break this. Nested groups are expanded to show their members, and cannot be removed from the UI. TopicUserMapping, on the other hand, works as expected; nested groups are listed by their name (not expanded to show their members), and can be properly added and removed with the UI.

See the partial, edited irc transcript below for discussion:

[10:38am] MichaelDaum: tsnfoo, do you use Ldap groups only? or do you mix it with topic-based groups?
[10:38am] tsnfoo: Mix
[10:38am] MichaelDaum: and now you are trying to edit a non-ldap group using the new user interface?
[10:38am] MichaelDaum: while LdapContrib is enabled, right?
[10:39am] tsnfoo: MichaelDaum: yes
[10:39am] gac410: MichaelDaum: The changes for group expansion had to propagate a new expand= parameter down through  the API's  and also add a new unexpanded group cache.
[10:40am] gac410: Because the GROUPINFO uses the cache to display the group, it needed to have an unexpanded version.
[10:40am] MichaelDaum: ... to supress expanding nested groups is it?
[10:41am] gac410: yes.  Otherwise the groups UI can never see the nested groups to be able to edit them.
[10:42am] MichaelDaum: okay. so I suspect there's a topic group nexting an ldap-group, tsnfoo?
[10:42am] MichaelDaum: or a similar mix
[10:43am] gac410: The unit tests for GROUPINFO beat on the expansion a bit - but I don't know if there is a way to test with LDAP groups.
[10:46am] tsnfoo: MichaelDaum: I'm seeing the problem on pure wiki groups
[10:46am] tsnfoo: (e.g., ParentGroups and ChildGroup are standard foswiki groups)
[10:48am] tsnfoo: MichaelDaum: LdapContrib and LdapUserMapping are enabled, using a mix of Ldap and Wiki groups, seeing the problem when nesting to pure wiki groups (not ldap)
[10:49am] MichaelDaum: tsnfoo, okay, now try $Foswiki::cfg{UserMappingManager} = 'Foswiki::Users::TopicUserMapping'; instead of LdapUserMapping
[10:52am] tsnfoo: MichaelDaum: I changed to TopicUserMapping; nested groups no longer expand as listed in WikiGroups, and I can add/delete them in the UI.
[10:53am] MichaelDaum: okay. thanks. will investigate.

-- AaronFuleki - 15 Dec 2010

Fixed in LdapContrib 4.30 4.31

-- MichaelDaum - 16 Dec 2010