You are here: Foswiki>Tasks Web>Item10335 (14 Apr 2011, PaulHarvey)Edit Attach

Item10335: UserRegistration javascript blocks submit

pencil
Priority: Urgent
Current State: Closed
Released In: n/a
Target Release: minor
Applies To: Engine
Component: JQueryPlugin
Branches:
Reported By: GeorgeClark
Waiting For:
Last Change By: PaulHarvey
Registration is blocked on trunk. Javascript seems to block the Submit button. Errors include:

Warning: The 'charCode' property of a keyup event should not be used. The value is meaningless.
Source File: http://.....com/System/UserRegistration
Line: 0

Warning: Unknown pseudo-class or pseudo-element 'submit'.
Source File: http://foswiki.fenachrone.com/System/UserRegistration
Line: 0

Also, the last name is not capitalized when building the WikiName from First / Last. I expect this is proper, since there are last names like deMarco, where it isn't first letter that is capitalized. .. although it would still might be better to have JamesDeMarco vs. JamesdeMarco ???

-- GeorgeClark - 10 Feb 2011

it looks like it disables when only the first pwd has been entered, and then doesn't reenable when both are the same -

there is some pretty strong talk suggesting that having a confirm pwd is a bit pointless - can re remove it too? (as reset works)

-- SvenDowideit - 10 Feb 2011

confirm pwd is a configure setting. We can ship it as 0 by default.

-- ArthurClemens - 15 Mar 2011

Something is still not right with the regstration screen Javascript. There seems to be a long delay between entering / leaving the 2nd password field and the submit button being enabled. If I type 1st password, tab, 2nd password, tab ... the Register button gets the focus, dotted outline, but remains grey/inactive. So I sit waiting to click with the mouse. Even with it grey, click at it enough, and it seems to submit and register. If I type-tab-type-Enter, then the button changes from grey to blue, and the registration is submitted.

With the delays I that I would double-enter at times causing errors. As soon as the focus leaves the 2nd password, be it by mouse click or tab ... or maybe as soon as the password matches, the register button should activate.

Also still getting 100's of the above errors when using the Register dialog.

-- GeorgeClark - 18 Mar 2011

Which browser does this to you?

-- ArthurClemens - 18 Mar 2011

Mozilla Firefox 3.6.15 And Chromium 10.0 as well. I just updated both of them, same behavior on trunk. The only way that I have found to get the Resister button to turn blue is to press Enter in the 2nd password. Tabbing away or clicking away don't do it,

Build identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.15) Gecko/20110317 Gentoo Firefox/3.6.15

Chromium   10.0.648.133 (Developer Build 0)
WebKit   534.16 (@0)
V8   3.0.12.30
User Agent   Mozilla/5.0 (X11; U; Linux i686; en-US) AppleWebKit/534.16 (KHTML, like Gecko) Chrome/10.0.648.133 Safari/534.16
Command Line    /usr/lib/chromium-browser/chrome --extra-plugin-dir=/usr/lib/nsbrowser/plugins --flag-switches-begin --flag-switches-end

-- GeorgeClark - 18 Mar 2011

The problem appears to be that with remote data, once the data is received, validate plugin does not reduce the number of errors in its stack.

Test case:
  1. Without entering any data, click on Register. You will see a lot of red marked fields.
  2. In the first field type Aa
  3. In the second field type Bb, quickly followed by a number of tabs, until you are at the end
  4. At this point, data for WikiName is still being retrieved. When the data comes in, validator.numberOfInvalids() returns the same number of errors (one too many)

I have patched the upstream code, and added a bug comment https://github.com/jzaefferer/jquery-validation/issues/#issue/12/comment/891376

-- ArthurClemens - 18 Mar 2011

This is still broken.

-- PaulHarvey - 01 Apr 2011

The issue is a dependency on RenderPlugin. Registration form fails unless this is installed.

-- PaulHarvey - 01 Apr 2011

Where's RenderPlugin used in foswiki core's registration form? That's only the case in the NatSkin version in System.UserRegistrationViewTemplate.

-- MichaelDaum - 14 Apr 2011

Oops, my mistake.

-- PaulHarvey - 14 Apr 2011
 

ItemTemplate edit

Summary UserRegistration javascript blocks submit
ReportedBy GeorgeClark
Codebase trunk
SVN Range 10676
AppliesTo Engine
Component JQueryPlugin
Priority Urgent
CurrentState Closed
WaitingFor
Checkins distro:4c1a54174714
TargetRelease minor
ReleasedIn n/a
Topic revision: r18 - 14 Apr 2011, PaulHarvey
The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. See Copyright Statement. Creative Commons License    Legal Imprint    Privacy Policy