You are here: Foswiki>Tasks Web>Extension>DirectedGraphWebMapPlugin>Item10337 (10 Feb 2011, RitBan)Edit Attach

Item10337: DirectedGraphWebMapPlugin doesn't work on windows: taint issue

Priority: Normal
Current State: Waiting for Feedback
Released In: n/a
Target Release: n/a

Applies To: Extension
Component: DirectedGraphWebMapPlugin
Branches:

Reported By: RitBan
Waiting For: Main.MichaelTempest
Last Change By: RitBan

RitBan opened a support ticket because DirectedGraphWebMapPlugin doesn't work on windows.

As I quickly diagnosed on IRC, it's due to the taint effect of File::Find on windows, because some characters such as : are not untainted by default.

Fix is simple, and I've used it on UnitTestContrib/lib/Unit/TestRunner.pm: add : to the untaint_pattern used by File::Find.

Opening a task so I can commit a fix.

Fixed the code, waiting for MichaelTempest to release.

-- OlivierRaginel - 10 Feb 2011

I tried out the patch on my setup and it seems to work fine over several edit and topic move/rename/parent change operations -- RitBan

-- RitBan - 10 Feb 2011

ItemTemplate edit

Summary	DirectedGraphWebMapPlugin doesn't work on windows: taint issue
ReportedBy	RitBan
Codebase	trunk
SVN Range
AppliesTo	Extension
Component	DirectedGraphWebMapPlugin
Priority	Normal
CurrentState	Waiting for Feedback
WaitingFor	MichaelTempest
Checkins	DirectedGraphWebMapPlugin:dbe0b4286e68
TargetRelease	n/a
ReleasedIn	n/a