You are here: Foswiki>Tasks Web>Extension>ExplicitNumberingPlugin>Item10435 (04 May 2011, AndrewJones)Edit Attach

Item10435: unconditional call to writeDebug

Priority: Low
Current State: Closed
Released In: n/a
Target Release: n/a

Applies To: Extension
Component: ExplicitNumberingPlugin
Branches:

Reported By: DiabJerius
Waiting For:
Last Change By: AndrewJones

There's a call to writeDebug which isn't conditional upon $debug being set. Here's a patch to fix it:

--- /var/www/default/templates/Foswiki-1.1.2/lib/Foswiki/Plugins/ExplicitNumberingPlugin.pm     2010-02-22 20:13:36.000000000 -0500
+++ lib/Foswiki/Plugins/ExplicitNumberingPlugin.pm      2011-03-02 16:52:12.000000000 -0500
@@ -111,7 +111,8 @@
     {
         {
             Foswiki::Func::writeDebug(
-                'ExplicitNumbering  - Disabled  - not view  context');
+                'ExplicitNumbering  - Disabled  - not view  context')
+                       if $debug;
             return ;
         }
     }

-- DiabJerius - 02 Mar 2011

Was already done in SVN. Now released.

-- AndrewJones - 04 May 2011

ItemTemplate edit

Summary	unconditional call to writeDebug
ReportedBy	DiabJerius
Codebase	1.1.2
SVN Range
AppliesTo	Extension
Component	ExplicitNumberingPlugin
Priority	Low
CurrentState	Closed
WaitingFor
Checkins	ExplicitNumberingPlugin:25cf8c24937d ExplicitNumberingPlugin:1b43ebbba5f8
TargetRelease	n/a
ReleasedIn	n/a