Item10455: pseudo-install need to ignore ONLYIF dependencies
Priority: Normal
Current State: Closed
Released In: 1.1.6
Target Release: patch
Applies To: Engine
Component:
Branches: Release01x01 trunk
pseudo-install cries "Wolf" all the time about missing dependencies.
They are bogus and a result of not understanding ONLYIF
I do not think we need it to be very intelligent. Just ignoring ONLYIF and all that follows is probably OK for development as a dev will not be pseudo-installing on an old release. And if he is he will need to figure out this dependency without this noise.
It is bad to send bogus errors because it means we all go blind when a new and important errors shows up.
--
KennethLavrsen - 08 Mar 2011
The "fix" committed to pseudo-install is anything but.
--
CrawfordCurrie - 20 Aug 2012
Fixed it properly.
--
CrawfordCurrie - 29 Aug 2012
Not quiet... See, in
pseudo-install.pl
, when we require a module, the code looks like this:
{
local $SIG{__WARN__};
return eval "require $mod; 1"
}
The reason being that requiring a module might fiddle with
$SIG{__WARN__}
. Eg: you require
Foswiki
and you have
FOSWIKI_ASSERTS=1
, then
Foswiki
will set
$SIG{__WARN__}
to
die
. Good luck debuggin that, took me 2h even though I was the one putting the aforementionned code in the first place.
Anyway, I've fixed both entries, and now it passes.
--
OlivierRaginel - 02 Sep 2012