Item10545: Webnotify for Abc*Xyz? doesn't send out news on change.

• SumNut: NewsLetter*Topic? Last notification was at 2011-03-26T01:30:50Z

Processing Sandbox
   * %USERSWEB%.BlergBloog: NewsLetter*Topic?
   * %USERSWEB%.SumNut: NewsLetter*Topic?
   Last notification was at 2011-03-26T01:43:40Z
   Change to NewsLetter123456Topic at 2011-03-26T01:49:45Z. New revision is 3
Sent newletter for Sandbox to gac@private.net
Set-Cookie: FOSWIKISID=5c7e09c7cc83e7e904d1a71b81ec4dc4; domain=private.com; path=/; HttpOnly

• NewsLetterMReGenerator
• NewsLetterMReList
• NewsLetterMReForm
• NewsLetterMReTemplate

   * Main.MartinRaabe: NewsLetterMRe*Topic?

Processing Sandbox
   * %USERSWEB%.MartinRaabe: NewsLetterMRe*Topic?
   Last notification was at 2011-03-26T01:56:03Z
   Change to WebNotify at 2011-03-27T01:49:17Z. New revision is 3
   Change to NewsLetterMRe2011x03x26Topic at 2011-03-27T01:47:21Z. New revision is 1
   Change to WebPreferences at 2011-03-27T01:46:30Z. New revision is 3
   Change to NewsLetterMReList at 2011-03-27T01:44:22Z. New revision is 1
   Change to NewsLetterMReGenerator at 2011-03-27T01:43:33Z. New revision is 1
   Change to NewsLetterMReTemplate at 2011-03-27T01:42:08Z. New revision is 1
   Change to NewsLetterMReForm at 2011-03-27T01:41:04Z. New revision is 1
Sent newletter for Sandbox to martinraabe@mydomain.com
Set-Cookie: FOSWIKISID=56b6e355d1d51d004aea29e3e667b135; domain=mydomain.com; path=/; HttpOnly

Processing Sandbox
   * %USERSWEB%.MartinRaabe: NewsLetterMRe*Topic?
   Last notification was at 2011-03-27T01:49:17Z
   Change to NewsLetterMRe2011x03x26bTopic at 2011-03-27T01:59:42Z. New revision is 1
Sent newletter for Sandbox to martinraabe@mydomain.com
Set-Cookie: FOSWIKISID=56b6e355d1d51d004aea29e3e667b135; domain=mydomain.com; path=/; HttpOnly

• If you do a force new revision save to the topic, and then publish, ensuring that there is no intervening cron triggered run, does your NewsLetter get published.
• If you manually edit the MailerContrib/[My web] token and set it to a lower number. (It's a timestamp in Unix epoch seconds) does that allow it to publish.
• If you remove the MailerContrib/[My web] token for your web, does your newsletter get published? (That should cause all newsletters to be sent!)

Default state of the Minor Changes, Don't Notify (DontNotify) check box in preview. Check box is initially checked if Set DONTNOTIFYCHECKBOX = checked="checked", or unchecked if empty: (can be overwritten by user preferences)

* Set DONTNOTIFYCHECKBOX =

   * %USERSWEB%.WikiGuest: NewsLetter*Topic?
        Last notification was at 2011-03-29T07:32:47Z
        Change to NewsLetter2011x03x29Topic at 2011-03-29T12:34:12Z. New revision is 1

• The "nochanges" and "nonews" parameters need to have a value passed in the rest interface. nochanges=1, where as the documented cli interface is to pass -nochanges
• The script appears to optimize the wildcards and throws away news subscriptions if a more generic wildcard matches. So Coding either on separate lines or on a single statement Main.MyUser: * News*Letter? - the Newsletter subscription is discarded.
• The nochanges option appears to also disable the newsletter. nonews prevents the newsletter and sends changes. nochanges doesn't send either.

diff --git a/MailerContrib/lib/Foswiki/Contrib/MailerContrib/Subscription.pm b/MailerContrib/lib/Foswiki/Contrib/MailerContrib/Subscription.pm
index f1ec18a..93100a7 100644
--- a/MailerContrib/lib/Foswiki/Contrib/MailerContrib/Subscription.pm
+++ b/MailerContrib/lib/Foswiki/Contrib/MailerContrib/Subscription.pm
@@ -119,16 +119,27 @@ specified by another subscription. Thus:
 sub covers {
     my ( $this, $tother, $db ) = @_;
 
-    #* should win always.
-    return 1 if ( $this->{topics} eq '*' );
+    print "COVERS - checking $this->{topics} $this->{options} against $tother->{topics} $tother->{options} \n";
 
     # Does the mode cover the other subscription?
-    return 0
-      unless (
-        ( $this->{options} & $tother->{options} ) == $tother->{options} );
+    unless (
+      ( $this->{options} & $tother->{options} ) == $tother->{options} ) {
+        print " .. RETURN 0 - options mismatch\n";
+        return 0;
+    }
+
+    # * should win always unless 
+    if ( $this->{topics} eq '*'
+      ) {
+      print " .. RETURN 1 - covered\n";
+      return 1;
+      }
 
     # do they match without taking into account the depth?
-    return 0 unless ( $this->matches( $tother->{topics}, undef, 0 ) );
+    unless ( $this->matches( $tother->{topics}, undef, 0 ) ) {
+        print " .. RETURN 0 - topic regex mismatch\n";
+        return 0;
+    }
 
     # if we have a depth and they don't, that's already catered for
     # by the matches test above
@@ -138,7 +149,12 @@ sub covers {
 
     # if we have a depth and they have a depth, then there is coverage
     # if our depth is >= their depth
-    return 0 unless ( $this->{depth} >= $tother->{depth} );
+    unless ( $this->{depth} >= $tother->{depth} ) {
+        print " .. RETURN 0 - depth exceeded\n";
+        return 0;
+    }
+
+    print " .. RETURN 1 - default\n";
 
     return 1;
 }
x

Processing Private
   * Main.OttoPublic: NewsLetter*Topic?
	Last notification was at 2011-03-29T21:34:53Z
	Change to NewsLetter2011x03x29Topic at 2011-03-29T21:37:55Z. New revision is 13
Set-Cookie: FOSWIKISID=178d3e3c06573b45985b5a086b9ffad3; path=/; HttpOnly

• mailnotify.log: Log of calling mailnotify from the shell