Item10730: Incompatible with Foswiki version prior to 1.1

pencil
Priority: Urgent
Current State: No Action Required
Released In: n/a
Target Release: n/a
Applies To: Extension
Component: DebianPackage, FormPlugin
Branches:
Reported By: PhilippLeufke
Waiting For:
Last Change By: ArthurClemens
The rewritten FormPlugin uses features which aren't present in Foswiki versions < 1.1; e.g. getRequestObject() or FieldFactory.

Unfortunately the dependency is not clarified in FormPlugin and Sven's debian packages from fosiki.org feature the new FormPlugin but not the necessary Foswiki 1.1, which for this reason broke our system quite badly.

I tried fixing the first issue along the suggestion in Support.Question609, but then I still get the error about FieldFactory:

Foswiki detected an internal error - please check your Foswiki logs and webserver logs for more information.

Foswiki::Plugins::FormPlugin::Renderer::Html::FieldFactory : Could not create field of type dropdown.

As I don't have any previous versions of the FormPlugin debian packages, I will now have to fix the problem manually by copying files from my backup.

This is really a bad situation; a package-based upgrade should not screw a whole foswiki system!

See also: Item10067

-- PhilippLeufke - 10 May 2011

On the FieldFactory error: either !Dropdown.pm is missing, or the file gives an error that must be written to your apache's error log.

On getRequestObject: I must create a version check in the code.

-- ArthurClemens - 10 May 2011

I have updated the plugin, version 2.0.1.

-- ArthurClemens - 12 May 2011

are things better now that we have a 1.1.3 deb?

-- SvenDowideit - 15 May 2011

With 1.1.3, things are a bit better, but I still have the FieldFactory issue:

[Mon May 16 16:11:47 2011] [error] Foswiki::Plugins::FormPlugin::Renderer::Html::FieldFactory : Could not create field of type text.
[Mon May 16 16:11:47 2011] [error]  at /usr/share/perl5/CGI/Carp.pm line 354
[Mon May 16 16:11:47 2011] [error] \tCGI::Carp::realdie('Foswiki::Plugins::FormPlugin::Renderer::Html::FieldFactory : ...') called at /usr/share/perl5/CGI/Carp.pm line 439
[Mon May 16 16:11:47 2011] [error] \tCGI::Carp::die('Foswiki::Plugins::FormPlugin::Renderer::Html::FieldFactory : ...') called at /var/lib/foswiki/lib/Foswiki/Plugins/FormPlugin/Renderer/Html/FieldFactory.pm line 22
[Mon May 16 16:11:47 2011] [error] \tFoswiki::Plugins::FormPlugin::Renderer::Html::FieldFactory::getField('text') called at /var/lib/foswiki/lib/Foswiki/Plugins/FormPlugin/Renderer/Html/FieldRenderer.pm line 41
[Mon May 16 16:11:47 2011] [error] \tFoswiki::Plugins::FormPlugin::Renderer::Html::FieldRenderer::render('Foswiki::Plugins::FormPlugin::Renderer::Html::FieldRenderer=H...', 'Foswiki::Plugins::FormPlugin::FieldData=HASH(0x48d5e40)', 'Foswiki::Plugins::FormPlugin::FormData=HASH(0x463bc70)') called at /var/lib/foswiki/lib/Foswiki/Plugins/FormPlugin.pm line 307
[Mon May 16 16:11:47 2011] [error] \tFoswiki::Plugins::FormPlugin::_formElement('Foswiki=HASH(0x23edec8)', 'Foswiki::Attrs=HASH(0x4918c00)', 'FormPlugin', 'System', 'Foswiki::Meta=HASH(0x4573900)') called at /var/lib/foswiki/lib/Foswiki/Func.pm line 570
[Mon May 16 16:11:47 2011] [error] \tFoswiki::Func::__ANON__('Foswiki=HASH(0x23edec8)', 'Foswiki::Attrs=HASH(0x4918c00)', 'Foswiki::Meta=HASH(0x4573900)') called at /var/lib/foswiki/lib/Foswiki.pm line 3037
[Mon May 16 16:11:47 2011] [error] \tFoswiki::_expandMacroOnTopicRendering('Foswiki=HASH(0x23edec8)', 'FORMELEMENT', '\\x{a}\\x{9}name="Name"\\x{a}\\x{9}type="text"\\x{a}\\x{9}title="Your name:"\\x{a}\\x{9}mandatory="on"\\x{a}', 'Foswiki::Meta=HASH(0x4573900)') called at /var/lib/foswiki/lib/Foswiki.pm line 2927
[Mon May 16 16:11:47 2011] [error] \tFoswiki::_processMacros('Foswiki=HASH(0x23edec8)', '%IF{"defined Name and $ Name != \\'\\'" then="---+!! Hello %URL...', 'CODE(0x2cbd0d0)', 'Foswiki::Meta=HASH(0x4573900)', 16) called at /var/lib/foswiki/lib/Foswiki.pm line 2724
[Mon May 16 16:11:47 2011] [error] \tFoswiki::innerExpandMacros('Foswiki=HASH(0x23edec8)', 'SCALAR(0x2ccc6c8)', 'Foswiki::Meta=HASH(0x4573900)') called at /var/lib/foswiki/lib/Foswiki.pm line 3214
[Mon May 16 16:11:47 2011] [error] \tFoswiki::expandMacros('Foswiki=HASH(0x23edec8)', '%IF{"defined Name and $ Name != \\'\\'" then="---+!! Hello %URL...', 'Foswiki::Meta=HASH(0x4573900)') called at /var/lib/foswiki/lib/Foswiki/Meta.pm line 3100
[Mon May 16 16:11:47 2011] [error] \tFoswiki::Meta::expandMacros('Foswiki::Meta=HASH(0x4573900)', '%IF{"defined Name and $ Name != \\'\\'" then="---+!! Hello %URL...') called at /var/lib/foswiki/lib/Foswiki/UI/View.pm line 400
[Mon May 16 16:11:47 2011] [error] \tFoswiki::UI::View::_prepare('%IF{"defined Name and $ Name != \\'\\'" then="---+!! Hello %URL...', 'Foswiki::Meta=HASH(0x4573900)', 0) called at /var/lib/foswiki/lib/Foswiki/UI/View.pm line 380
[Mon May 16 16:11:47 2011] [error] \tFoswiki::UI::View::view('Foswiki=HASH(0x23edec8)') called at /var/lib/foswiki/lib/Foswiki/UI.pm line 316
[Mon May 16 16:11:47 2011] [error] \tFoswiki::UI::__ANON__() called at /usr/share/perl5/Error.pm line 416
[Mon May 16 16:11:47 2011] [error] \teval {...} called at /usr/share/perl5/Error.pm line 408
[Mon May 16 16:11:47 2011] [error] \tError::subs::try('CODE(0x23caf10)', 'HASH(0x23eda90)') called at /var/lib/foswiki/lib/Foswiki/UI.pm line 435
[Mon May 16 16:11:47 2011] [error] \tFoswiki::UI::_execute('Foswiki::Request=HASH(0x26b1e10)', 'CODE(0x2cf5978)', 'view', 1) called at /var/lib/foswiki/lib/Foswiki/UI.pm line 277
[Mon May 16 16:11:47 2011] [error] \tFoswiki::UI::handleRequest('Foswiki::Request=HASH(0x26b1e10)') called at /var/lib/foswiki/lib/Foswiki/Engine/CGI.pm line 37
[Mon May 16 16:11:47 2011] [error] \tFoswiki::Engine::CGI::run('Foswiki::Engine::CGI=HASH(0x26b2bf0)') called at /var/lib/foswiki/bin/view line 24.
[Mon May 16 16:11:47 2011] [error] File does not exist: /var/www/favicon.ico

Could you try to use the files attached to Support.Question861 to see if you get a more detailed report?

-- ArthurClemens - 16 May 2011

I just tried, but using the replacements for FieldFactory.pm and RendererFactory.pm at the same time is troublesome: FormPlugin then only gets listed as (disabled) in InstalledPlugins and existing FORMFIELD macros don't get rendered, consequently. Using only one of the two files will result in an error message in the webbrowser, complaining about the other of the two files which was kept unchanged.

I enabled the debug mode for the plugin, but it doesn't seem to write the debug.txt file where it claims to do so.

Maybe the foswiki warm.log entry gives a hint:

| 2011-05-17T10:40:12Z warning | Foswiki::Plugins::FormPlugin::Renderer::Html::FieldFactory : Could not create field of type text.
 at /usr/share/perl5/CGI/Carp.pm line 354
   CGI::Carp::realdie('Foswiki::Plugins::FormPlugin::Renderer::Html::FieldFactory : ...') called at /usr/share/perl5/CGI/Carp.pm line 439
   CGI::Carp::die('Foswiki::Plugins::FormPlugin::Renderer::Html::FieldFactory : ...') called at /var/lib/foswiki/lib/Foswiki/Plugins/FormPlugin/Renderer/Html/FieldFactory.pm line 22
   Foswiki::Plugins::FormPlugin::Renderer::Html::FieldFactory::getField('text') called at /var/lib/foswiki/lib/Foswiki/Plugins/FormPlugin/Renderer/Html/FieldRenderer.pm line 41
   Foswiki::Plugins::FormPlugin::Renderer::Html::FieldRenderer::render('Foswiki::Plugins::FormPlugin::Renderer::Html::FieldRenderer=H...', 'Foswiki::Plugins::FormPlugin::FieldData=HASH(0x335a900)', 'Foswiki::Plugins::FormPlugin::FormData=HASH(0x30d4578)') called at /var/lib/foswiki/lib/Foswiki/Plugins/FormPlugin.pm line 307
   Foswiki::Plugins::FormPlugin::_formElement('Foswiki=HASH(0xdfcee0)', 'Foswiki::Attrs=HASH(0x339ed38)', 'FormPlugin', 'System', 'Foswiki::Meta=HASH(0x300cc30)') called at /var/lib/foswiki/lib/Foswiki/Func.pm line 570
   Foswiki::Func::__ANON__('Foswiki=HASH(0xdfcee0)', 'Foswiki::Attrs=HASH(0x339ed38)', 'Foswiki::Meta=HASH(0x300cc30)') called at /var/lib/foswiki/lib/Foswiki.pm line 3037
   Foswiki::_expandMacroOnTopicRendering('Foswiki=HASH(0xdfcee0)', 'FORMELEMENT', '\x{a}\x{9}name="Name"\x{a}\x{9}type="text"\x{a}\x{9}title="Your name:"\x{a}\x{9}mandatory="on"\x{a}', 'Foswiki::Meta=HASH(0x300cc30)') called at /var/lib/foswiki/lib/Foswiki.pm line 2927
   Foswiki::_processMacros('Foswiki=HASH(0xdfcee0)', '%IF{"defined Name and $ Name != \'\'" then="---+!! Hello %URL...', 'CODE(0x16cc128)', 'Foswiki::Meta=HASH(0x300cc30)', 16) called at /var/lib/foswiki/lib/Foswiki.pm line 2724
   Foswiki::innerExpandMacros('Foswiki=HASH(0xdfcee0)', 'SCALAR(0x16db6a0)', 'Foswiki::Meta=HASH(0x300cc30)') called at /var/lib/foswiki/lib/Foswiki.pm line 3214
   Foswiki::expandMacros('Foswiki=HASH(0xdfcee0)', '%IF{"defined Name and $ Name != \'\'" then="---+!! Hello %URL...', 'Foswiki::Meta=HASH(0x300cc30)') called at /var/lib/foswiki/lib/Foswiki/Meta.pm line 3100
   Foswiki::Meta::expandMacros('Foswiki::Meta=HASH(0x300cc30)', '%IF{"defined Name and $ Name != \'\'" then="---+!! Hello %URL...') called at /var/lib/foswiki/lib/Foswiki/UI/View.pm line 400
   Foswiki::UI::View::_prepare('%IF{"defined Name and $ Name != \'\'" then="---+!! Hello %URL...', 'Foswiki::Meta=HASH(0x300cc30)', 0) called at /var/lib/foswiki/lib/Foswiki/UI/View.pm line 380
   Foswiki::UI::View::view('Foswiki=HASH(0xdfcee0)') called at /var/lib/foswiki/lib/Foswiki/UI.pm line 316
   Foswiki::UI::__ANON__() called at /usr/share/perl5/Error.pm line 416
   eval {...} called at /usr/share/perl5/Error.pm line 408
   Error::subs::try('CODE(0xdd9f10)', 'HASH(0xdfcaa8)') called at /var/lib/foswiki/lib/Foswiki/UI.pm line 435
   Foswiki::UI::_execute('Foswiki::Request=HASH(0x10c0e28)', 'CODE(0x17049f0)', 'view', 1) called at /var/lib/foswiki/lib/Foswiki/UI.pm line 277
   Foswiki::UI::handleRequest('Foswiki::Request=HASH(0x10c0e28)') called at /var/lib/foswiki/lib/Foswiki/Engine/CGI.pm line 37
   Foswiki::Engine::CGI::run('Foswiki::Engine::CGI=HASH(0x10c1bf0)') called at /var/lib/foswiki/bin/view line 24.

-- PhilippLeufke - 17 May 2011

Bump...

-- PhilippLeufke - 25 May 2011

The FieldFactory issue is not caused by DebianPackage, as I found out. I'm opening a separate bug for this...

-- PhilippLeufke - 31 May 2011

Not caused?

-- ArthurClemens - 31 May 2011

Yep. not caused. See Item10811. -- PhilippLeufke - 31 May 2011

Resolved with Item10811.

-- ArthurClemens - 31 May 2011

 

ItemTemplate edit

Summary Incompatible with Foswiki version prior to 1.1
ReportedBy PhilippLeufke
Codebase 1.1.3, 1.0.10
SVN Range
AppliesTo Extension
Component DebianPackage, FormPlugin
Priority Urgent
CurrentState No Action Required
WaitingFor
Checkins FormPlugin:e9907ea40391 FormPlugin:ed22a7b7e6fb
TargetRelease n/a
ReleasedIn n/a
Topic revision: r15 - 31 May 2011, ArthurClemens
The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. See Copyright Statement. Creative Commons License    Legal Imprint    Privacy Policy