You are here: Foswiki>Tasks Web>Item11105 (17 Dec 2011, GeorgeClark)Edit Attach

Item11105: Saving an attachment stores "save attachment" string in version history, instead of the attachment comment

Priority: Urgent
Current State: Closed
Released In: 1.1.4
Target Release: patch

Applies To: Engine
Component:
Branches:

Reported By: ArthurClemens
Waiting For:
Last Change By: GeorgeClark

This line in lib/Foswiki/Store/VC/Store.pm has a comment hardcoded:

$handler->addRevisionFromStream( $stream, 'save attachment', $cUID );

This string shows up in the attachment version history table, where you would expect the comment of the attachment. And this means that the previous comments to that attachment are lost.

This did not happen in Release01x00 branch.

-- ArthurClemens - 04 Sep 2011

Added a unit test. Verified that the test fails with Arthur's fix reverted. Passes with fix applied.

-- GeorgeClark - 12 Sep 2011

ItemTemplate edit

Summary	Saving an attachment stores "save attachment" string in version history, instead of the attachment comment
ReportedBy	ArthurClemens
Codebase	1.1.3, trunk
SVN Range
AppliesTo	Engine
Component
Priority	Urgent
CurrentState	Closed
WaitingFor
Checkins	distro:23f4c96c94a4 distro:439d3bc89a0a distro:ae6efd5e31a4 distro:a19483d440ce
TargetRelease	patch
ReleasedIn	1.1.4