Item11189: Images referenced in square bracket link text are not rendered

pencil
Priority: Urgent
Current State: Closed
Released In: 1.1.4
Target Release: patch
Applies To: Engine
Component: FoswikiRender
Branches:
Reported By: GeorgeClark
Waiting For: Main.OlivierRaginel
Last Change By: GeorgeClark
Images referenced in square-bracket links are not working.

  • This is the Foswiki logo: foswiki-logo.png
  • This should be the same as above, but clickable, ending on WebHome: foswiki-logo.png

-- GeorgeClark - 20 Oct 2011

Integrated image testing in the right part of a square bracket link, factorized the image testing code, and allow spaces before and after the text.

Merged in the release branch too.

-- OlivierRaginel - 20 Oct 2011

Thank you very much for this quick fix!

-- BeatDoebeli - 20 Oct 2011

Have to reopen this bug as it breaks things seriously. This here should create a link to an image attachment with the image name as link text:

[[%ATTACHURLPATH%/img.jpg][img.jpg]]

Alas it creates a broken img tag:

<a href="%PUBURLPATH%/web/topic/img.jpg" target="_top"><img alt="img.jpg" src="img.jpg" /></a>

It should be:

<a href="%PUBURLPATH%/web/topic/img.jpg" target="_top">img.jpg</a>

... because that's what the bracket link says.

A

[[%ATTACHURLPATH%/img.jpg][<nop>img.jpg]]

... doesn't help either.

-- MichaelDaum - 25 Oct 2011

Right... seems the existing code was a bit odd. Trying to fix, and adding your examples to the unit tests

-- OlivierRaginel - 25 Oct 2011

Ok, committed also in the release branch. Closing again.

-- OlivierRaginel - 26 Oct 2011

 
Topic revision: r20 - 17 Dec 2011, GeorgeClark
The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. See Copyright Statement. Creative Commons License    Legal Imprint    Privacy Policy