Item11647: Only the first %HOLIDAYLIST macro works

copied from http://foswiki.org/Tasks/Item11310

After upgrading from Foswiki 1.1.2 with HolidaylistPlugin 1.032 to Foswiki 1.1.4 with HolidaylistPlugin 2.000, our team overview page no longer works:

It contains multiple %HOLIDAYLIST macro calls, each displaying one month. Before the update, each of them displayed a table. Since the upgrade, only the first macro is executed, for all others, no output is created.

Sample code posted here (is not executed, though, as the HolidaylistPlugin is not enabled on foswiki.org): PGHolidayTest

As the screenshot below shows, only one box is printed, even though the source code of the page contains multiple %HOLIDAYLIST macro calls.

This is due to a bug in Holidaylistplugin/Core.pm, where $expanding is a global variable now whereas it used to be local to HOLIDAYLISTPLUGIN() -- its purpose is to prevent endless recursion when reading the event list would cause the expansion of a %HOLIDAYLIST macro.

-- FlorianSchlichting - 15 Mar 2012

Commenting is disabled while not logged in