Item13293: double quotes in a topic title break rendering the title during edit

pencil
Priority: Normal
Current State: Confirmed
Released In: n/a
Target Release:
Applies To: Extension
Component: WikiWorkbenchContrib
Branches:
Reported By: MichaelDaum
Waiting For:
Last Change By: MichaelDaum
diff --git a/data/Applications/WikiTopicEditTemplate.txt b/data/Applications/WikiTopicEditTemplate.txt
index b1d88ec..f325eac 100644
--- a/data/Applications/WikiTopicEditTemplate.txt
+++ b/data/Applications/WikiTopicEditTemplate.txt
@@ -1,4 +1,4 @@
-%META:TOPICINFO{author="ProjectContributor" comment="" date="1418752972" format="1.1"  version="1"}%
+%META:TOPICINFO{author="micha" comment="reprev" date="1425651737" format="1.1" reprev="2" version="2"}%
 %META:TOPICPARENT{name="TopicView"}%
 %{<verbatim class="tml">}%
 %TMPL:INCLUDE{"edit"}%
@@ -38,8 +38,8 @@
 %{<verbatim class="tml">}%
 %TMPL:DEF{"contenttitle"}%<h1 class="natEditTitle">
 %IF{"istopic '%WEB%.%TOPIC%'"
-  then="[[%WEB%.%TOPIC%][%TMPL:P{"topictitle"}%]] (%MAKETEXT{"edit [_1]" args="%TMPL:P{"topictype"}%"}%)"
-  else="<nop>%TMPL:P{"topictitle"}% (%MAKETEXT{"new [_1]" args="%TMPL:P{"topictype"}%"}%)"
+  then="[[%WEB%.%TOPIC%][$percntTMPL:P{\"topictitle\"}$percnt]] (%MAKETEXT{"edit [_1]" args="%TMPL:P{"topictype"}%"}%)"
+  else="<nop>$percntTMPL:P{\"topictitle\"}$percnt (%MAKETEXT{"new [_1]" args="%TMPL:P{"topictype"}%"}%)"
 }%
 </h1>
</verbatim></verbatim>

-- MichaelDaum - 06 Mar 2015

Hello

Above patch does not work. And in my opinion, it just changes the rendering of title in h1.

We observer, that quotes in topic titles get lost in the topictitle input field.

How about:
*** /templates/edit.natedit.tmpl
23c23
< %TMPL:DEF{"topictitle_dbcache"}%%GETTOPICTITLE{"%WEB%.%TOPIC%" hideautoinc="%hideautoinc%"}%%TMPL:END%
---
> %TMPL:DEF{"topictitle_dbcache"}%%GETTOPICTITLE{"%WEB%.%TOPIC%" encode="entity" hideautoinc="%hideautoinc%"}%%TMPL:END%

-- AndreLichtsteiner - 06 Mar 2015

I think both patches are required. The first one definitely did fix a topic with a This is a "quote" inside a title ... which came out as

<h1>[[Web.TopicFoo][This is a</h1>

in the editor.

-- MichaelDaum - 06 Mar 2015
 

ItemTemplate edit

Summary double quotes in a topic title break rendering the title during edit
ReportedBy MichaelDaum
Codebase
SVN Range
AppliesTo Extension
Component WikiWorkbenchContrib
Priority Normal
CurrentState Confirmed
WaitingFor
Checkins
ReleasedIn n/a
CheckinsOnBranches
trunkCheckins
masterCheckins
ItemBranchCheckins
Release01x01Checkins
Topic revision: r3 - 06 Mar 2015, MichaelDaum
The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. See Copyright Statement. Creative Commons License    Legal Imprint    Privacy Policy