Item13966: Rendering engine fails with HTML comments in HTML tag values

View the output of this topic using "View Source" in the browser. You will see that the trailing > gets replaced with >

this is caused in the rendering enginine, Render.pm between 341 and 356. A SMELL suggests this has been known about for a long time.

-- CrawfordCurrie - 18 Feb 2016

I'm going to demote this task to "normal" priority. I can't see blocking the next release over it. As you say, this has been in the code for a long time. From what I can tell from the logs, it was there on the import at the start of the project. So this cannot suddenly become a blocker now. As the comment goes on to say, this code assumes that any HTML tags internal to other HTML tags have been escaped.

+    # SMELL: this next fragment does not handle the case where HTML tags
+    # are embedded in the values provided to other tags. The only way to
+    # do this correctly is to parse the HTML (bleagh!). So we just assume
+    # they have been escaped.

-- GeorgeClark - 19 Mar 2016

Commenting is disabled while not logged in