Item13995: Search $changes renders a simple summary.

The bug is down in Search.pm.

-            $out =~ s/\$changes(?:\(([^\)]*)\))?/
-              $item->summariseChanges(Foswiki::Store::cleanUpRevID($1), $revNum)/ges;

If $changes is used, without a requested revision, the $1 is undefined. cleanUpRevID(undef) returns zero, and summariseChanges becomes a simple summary.

The fix is relatively easy, but this is going to break any search using $changes inside a table. The $summary renders without newlines, where as $changes generates a diff, and any newlines break the table.

There are multiple tasks dealing with the rather ineffective $changes option.

• No way to get a simple text summary, equivalent to $summary, except for the differences between the revisions See Item1390
• No way to ask for just the prior rev. See Item9464 $changes(n) asks for differences since rev n, which is hard to predict in a search.

-- GeorgeClark - 27 Feb 2016

Commenting is disabled while not logged in