You are here: Foswiki>Tasks Web>Item1476>ApprovalPlugin>Item14153 (25 Sep 2016, GeorgeClark)Edit Attach

Item14153: Approval Plugin not working with perl 5.22.1

pencil
Priority: Urgent
Current State: Confirmed
Released In: n/a
Target Release:
Applies To: Extension
Component: ApprovalPlugin
Branches:
Reported By: NicholasSushkin
Waiting For:
Last Change By: GeorgeClark
The switch in _handleTag is not working any longer in perl 5.22 for some reason. Had to rewrite without using the comma operator.

-- NicholasSushkin - 01 Sep 2016

Yes, this code seems to be really old perl 4 syntax, if I'm coming even close to understanding it. PerlCritic does detect the issue at "severity 4": 
Comma used to separate statements at line 220, column 9.  See pages 68,71 of PBP.  (Severity: 4)

-- GeorgeClark - 25 Sep 2016
 

ItemTemplate edit

Summary Approval Plugin not working with perl 5.22.1
ReportedBy NicholasSushkin
Codebase trunk
SVN Range
AppliesTo Extension
Component ApprovalPlugin
Priority Urgent
CurrentState Confirmed
WaitingFor
Checkins
ReleasedIn n/a
CheckinsOnBranches
trunkCheckins
masterCheckins
ItemBranchCheckins
Release02x01Checkins
Release02x00Checkins
Release01x01Checkins
I Attachment Action Size Date Who Comment
approval-plugin.patchpatch approval-plugin.patch manage 1 K 01 Sep 2016 - 23:18 NicholasSushkin patch to fix the issue
Edit  | Attach | Print version | History: r2 < r1 | Backlinks | View wiki text | Edit wiki text | More topic actions
Topic revision: r2 - 25 Sep 2016, GeorgeClark
The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. See Copyright Statement. Creative Commons License    Legal Imprint    Privacy Policy