You are here: Foswiki>Tasks Web>Item14447 (20 Aug 2018, MichaelDaum)Edit Attach

Item14447: _readKeyValues is a dog

Priority: Normal
Current State: Waiting for Release
Released In: 2.2.0
Target Release: minor

Applies To: Engine
Component:
Branches: master Item14288 Item14380 Item14537

Reported By: CrawfordCurrie
Waiting For:
Last Change By: MichaelDaum

If a SEARCH gets a lot of results, and then queries the formfields in those results, then each hit topic has to be loaded. This makes loading topics from disc quite critical. During this load, parsing of the meta-data is done by Foswiki::Serialise::Embedded. The critical code section here is _readKeyValues, which uses regexes in a clumsy and slow way. This can be improved on quite a bit.

Architecturally, the separation between searching a topic and querying it's formfields needs to be looked at more closely.

-- CrawfordCurrie - 28 Jul 2017

As this has only been checked in to master, this is waiting for 2.2.0 to be released ... instead of waiting for n/a

-- MichaelDaum - 20 Aug 2018

ItemTemplate edit

Summary	_readKeyValues is a dog
ReportedBy	CrawfordCurrie
Codebase
SVN Range
AppliesTo	Engine
Component
Priority	Normal
CurrentState	Waiting for Release
WaitingFor
Checkins	distro:cdb81af2b0a2
TargetRelease	minor
ReleasedIn	2.2.0
CheckinsOnBranches	master Item14288 Item14380 Item14537
trunkCheckins
masterCheckins	distro:cdb81af2b0a2
ItemBranchCheckins	distro:cdb81af2b0a2
Release02x01Checkins
Release02x00Checkins
Release01x01Checkins