You are here: Foswiki>Tasks Web>Item14455 (31 Jan 2018, GeorgeClark)Edit Attach

Item14455: Malformed System.AdminDocumentationCategory.

pencil
Priority: Normal
Current State: Closed
Released In: 2.1.5
Target Release: patch
Applies To: Engine
Component:
Branches: Release02x01 master Item14288 Item14454 Item14380 Item14537
Reported By: JulianLevens
Waiting For:
Last Change By: GeorgeClark
The side bar ends up on the right of the screen. This is on my local site and on foswiki.org.

The included content from ReleaseHistory is returning an extra </div> confusing the layout.

I quickly hacked the search in System.Category to excludetopic="ReleaseHistory" locally and the page then formatted correctly. Using developer tools in chrome and viewing the source allowed me to identify the extra </div>

It may be enough to amend the $pattern in System.Category to be smarter somehow.

However, there are other System topics locally that also behave like this — pushing the sidebar to the right — and I wonder if this issue is suggestive of a deeper problem in the render pipeline. I confess that I have little idea of the flow of stuff in the render pipeline frown, sad smile

-- JulianLevens - 02 Aug 2017

The solution is to just reorganize the ReleaseHistory a bit to make sure some text follows the ---+ heading. Then the pattern regex gets it right.

-- GeorgeClark - 04 Aug 2017

The regex assumes that there is a heading followed by at least a sentence of description. If the found topic does not follow this layout, it will scramble the results. I've fixed a few issues that messes up these topics. Setting this to waiting for release.

The core render code doesn't do anything to validate proper open/close sequences of divs. That sort of change probably needs a feature request.

-- GeorgeClark - 09 Aug 2017
 
Topic revision: r10 - 31 Jan 2018, GeorgeClark
The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. See Copyright Statement. Creative Commons License    Legal Imprint    Privacy Policy