Item14493: ICONURL and ICONURLPATH do not work with skin based ICONs.

ICON macro renders using templates provided by the icons.tmpl template. However the ICONURL and ICONURLPATH macros expect to find icons attached to DocumentGraphics. This means that template/skin based overrides of icons get ignored by macros referencing ICONURL / ICONURLPATH. (eg. TwistyPlugin)

See the discussion: irc logs

The icons.tmpl and the ICON.pm module needs some redesign so that ICON, ICONURL and ICONURLPATH are all consistently expanded.

Note also that icons.tmpl is shipped as part of FamFamFamContrib, but is used the core ICON.pm macro. This breaks the boundaries between core and extensions.

-- GeorgeClark - 20 Sep 2017

And... icons.tmpl (from FamFamFamContrib) overrides the icon:image template defined in foswiki.tmpl. It "fixes" a template that mixed single and double quotes in the html. The code in Foswiki::Render::IconImage depends on the first detected quote to fix-up the single or double quotes. Mixed quotes in the base template breaks the quote= option of the ICON macro.

There is also an apparently unused icon:image_singlequote template defined in foswiki.tmpl.

-- GeorgeClark - 27 Sep 2017

Commenting is disabled while not logged in