You are here: Foswiki>Tasks Web>Item14899 (30 Mar 2020, MichaelDaum)Edit Attach

Item14899: jsonrpc rewrite in 2.2 is incompatible with JsonRpcContrib

Priority: Urgent
Current State: Confirmed
Released In: n/a
Target Release: minor

Applies To: Engine
Component: Foswiki::Request
Branches:

Reported By: MichaelDaum
Waiting For:
Last Change By: MichaelDaum

A Foswiki::Request::JSON class was added to 2.2.0 that tries to reimplement the calling semantics from JsonRpcContrib. Alas, this implementation is broken in various ways. Handling of json post data and url parameters are totally different up to the point that wiki apps and plugins written for 2.1.x using JsonRpcContrib are incompatible on 2.2.0.

As I don't understand why George did that and am unable to fix the code up to the point it matches JsonRpcContrib. Nor do I see a reason to fix a rewrite where the original code worked just fine. So I tend to revert these changes to 2.2.0 to the point JsonRpcContrib's request and response classes are used again.

In the meantime George has long left the community so he is not available for answers anymore...

-- MichaelDaum - 30 Mar 2020

ItemTemplate edit

Summary	jsonrpc rewrite in 2.2 is incompatible with JsonRpcContrib
ReportedBy	MichaelDaum
Codebase
SVN Range
AppliesTo	Engine
Component	Foswiki::Request
Priority	Urgent
CurrentState	Confirmed
WaitingFor
Checkins
TargetRelease	minor
ReleasedIn	n/a
CheckinsOnBranches
trunkCheckins
masterCheckins
ItemBranchCheckins
Release02x01Checkins
Release02x00Checkins
Release01x01Checkins