You are here: Foswiki>Tasks Web>Item15151 (01 Jul 2022, MichaelDaum)Edit Attach

Item15151: Perl::Critic flagging issues

Priority: Normal
Current State: New
Released In: n/a
Target Release: n/a

Applies To: Engine
Component:
Branches: Release02x01 master

Reported By: MichaelDaum
Waiting For:
Last Change By: MichaelDaum

I recently dived into Perl::Critic and found it to be a massively useful tool. Only problem is on agreeing or not with the findings it makes and thus configure it to our needs. Perl Best Practice is quite a reading. Perl::Critic regularly refers to it with a page number the test is based on. Some of the arguing there is a bit questionable but that's why Perl::Critic can be customized to the own coding standards.

See Development.PerlCritic for more.

For issues still being reported as a violation we can decide to sanction them using "## no critic" comments, as in

no warnings 'redefine'; ## no critic
...
warnings 'redefine';

This too is a common pattern in Foswiki while "monkey patching" code already loaded.

-- MichaelDaum - 29 Jun 2022

ItemTemplate edit

Summary	Perl::Critic flagging issues
ReportedBy	MichaelDaum
Codebase	2.2.0, 2.1.8
SVN Range
AppliesTo	Engine
Component
Priority	Normal
CurrentState	New
WaitingFor
Checkins	distro:72d2c155078b distro:6eded1bd906f distro:fc80dbda6123 distro:ab6403fa8831 distro:85e86e1e21c9 distro:3875b2b33c26 distro:894282d76f9a distro:79228de06b81 distro:7a11b1d0903e distro:29d3bd4803f6
TargetRelease	n/a
ReleasedIn	n/a
CheckinsOnBranches	Release02x01 master
trunkCheckins
masterCheckins	distro:6eded1bd906f distro:ab6403fa8831 distro:3875b2b33c26 distro:79228de06b81 distro:29d3bd4803f6
ItemBranchCheckins
Release02x01Checkins	distro:72d2c155078b distro:fc80dbda6123 distro:85e86e1e21c9 distro:894282d76f9a distro:7a11b1d0903e
Release02x00Checkins
Release01x01Checkins