Item1693: LINKTOOLTIPINFO causes massive performance drop

Foswiki has a massive performance problem when LINKTOOLTIPINFO is enabled. As discused today with my colleague "burns" on IRC a page with a 109 revisions took >10s to render, the same page with disabled LINKTOOLTIPINFO only 2s.

It seems that if Foswiki::Meta::getRevisionInfo is called for object Foswiki::Meta created in Foswiki::Render::_linkToolTipInfo, the $text parameter of _new is empty ( http://irclogs.foswiki.org/bin/irclogger_log/foswiki?date=2009-06-08,Mon&sel=232#l228 ).

-- StefanPalm

---

I'm afraid I can't really reproduce this behavior, as this requires having a topic which links to a lot of internal topics, which all have a lot of revisions. Pretty hard to reproduce

Anyway, I've coded a patch to use cached data instead of accessing the store everytime.

• Item1693-useCachedData.patch: Use cached data for tooltips

I tried it locally and it seems to work just like it used to (no unit tests for now, so hard to know for sure).

I stumbled also on a bug when you have ASSERTS on, which I haven't fixed yet, because it used to be like that Yes, I will eventually fix it, once this is OK.

Stefan or Burns, would you be so kind as to test this on your installation, and report if it's better or not?

Thanks

-- Babar - 09 Jun 2009

---

We applied the patch and looks like the problem is solved. Rendering with enabled LINKTOOLTIPINFO is now as fast as with disbled ones. Great. Thank you very much for your help!

-- StefanPalm - 09 Jun 2009

Problem solved means waiting for release

Thanks Olivier for fixing a problem older than me.

PS: OK I know. This problem was not there during the war. The 1st WW

-- KennethLavrsen - 16 Jun 2009

Reopening. Not yet merged to trunk

-- KennethLavrsen - 16 Jun 2009

Ok, finally got time to merge this to trunk. Would be great if StefanPalm or somebody else with some good testing topics (with lots of internal links, each having some history) could report on this.

Closing it anyway, as it works for me and the tests I made.

-- OlivierRaginel - 11 Jul 2009