You are here: Foswiki>Tasks Web>Item1987 (15 Sep 2009, PaulHarvey)Edit Attach

Item1987: Breaks TinyMCE CSS

pencil
Priority: Urgent
Current State: Closed
Released In:
Target Release: n/a
Applies To: Extension
Component: NatSkin
Branches:
Reported By: PaulHarvey
Waiting For:
Last Change By: PaulHarvey
Running trunk NatSkin and TinyMCEPlugin.

Bullets aren't displayed, unless you append Eg. &skin=pattern to the edit URL.

-- PaulHarvey - 30 Aug 2009

Using Firefox 3.0.6, apparently this is the case with FF 3.5x as well.

The issue seems to be the reset of padding and margin properties in BaseStyles.css.

-- PaulHarvey - 30 Aug 2009

A screenshot says more than 1k words wink

-- MichaelDaum - 31 Aug 2009

So you can't read my mind? Oops. Here it is smile

-- PaulHarvey - 31 Aug 2009

  • raw editor showing topic text:
    Sandbox - edit raw - Foswiki - Iceweasel 3.0.6.png

  • wysiwyg editor showing fault:
    Sandbox - edit wysiwyg - Foswiki - Iceweasel 3.0.6.png

  • wysiwyg editor showing hacked css without fault:
    Sandbox - edit wysiwyg hacked - Foswiki - Iceweasel 3.0.6.png


Okay. This is actually the result of a bad rendering of %NATSTYLEURL%, which gets assigned to %FOSWIKI_COLORS_URL% which in turn is used in TinyMCE's INIT settings.

Also this explains why I've been getting some HTTP Error 403's in my page views.

%NATSTYLEURL%
  • Expected: /pub/System/JazzyNoteTheme/JazzyNoteStyle.css
  • Actual: /pub/System/JazzyNoteTheme

Attached a diff to fix this problem.

-- PaulHarvey - 03 Sep 2009

Excellent smile

-- MichaelDaum - 03 Sep 2009

Main.MichaelTempest reports the fix works on IE8, Opera 10 and FF 3.52 smile

I set upgraded to urgent, because I thought this might be a small enough patch that we could get it commited soon for the 1.0.7 release?

-- PaulHarvey - 13 Sep 2009

Tested successfully in these browsers today:

  • IE 6.0.2900.5512.xpsp_sp3_gdr.090206-1234 (XP)
  • Firefox (Iceweasel) 3.0.12 (Linux)
  • Firefox 3.5.3 (XP)
  • Opera 10.00 (Linux)
  • Chrome 2.0.172.43 (XP)
  • Epiphany 2.22.3 (Linux)
  • Safari 4.0.3 (XP)

Actually I've found that BaseStyle.css kills WYSIWYG experience for users editing tables horrible frown, sad smile padding, margins, etc. set to 0... Working on this.

-- PaulHarvey - 14 Sep 2009

BaseStyle.css uses a css reset framework "borrowed" from common grid css frameworks. In the next NatSkin version all css for foswikiTables, their rows and cells will be applied to the related elements under mceContentBody. These didn't have any default css before other than what is applied by browsers themselves.

-- MichaelDaum - 14 Sep 2009

Michael, thank you very much for the NatSkin update, it makes everything look quite lovely smile

Tested successfully on all the browsers listed above.

-- PaulHarvey - 15 Sep 2009

ItemTemplate edit

Summary Breaks TinyMCE CSS
ReportedBy PaulHarvey
Codebase 1.0.6, trunk
SVN Range Foswiki-1.0.0, Thu, 08 Jan 2009, build 1878
AppliesTo Extension
Component NatSkin
Priority Urgent
CurrentState Closed
WaitingFor
Checkins NatSkin:fc073fe9a313
TargetRelease n/a
ReleasedIn
I Attachment Action Size Date Who Comment
Sandbox_-_edit_raw_-_Foswiki_-_Iceweasel_3.0.6.pngpng Sandbox_-_edit_raw_-_Foswiki_-_Iceweasel_3.0.6.png manage 45 K 31 Aug 2009 - 10:04 PaulHarvey raw editor
Sandbox_-_edit_wysiwyg_-_Foswiki_-_Iceweasel_3.0.6.pngpng Sandbox_-_edit_wysiwyg_-_Foswiki_-_Iceweasel_3.0.6.png manage 86 K 31 Aug 2009 - 10:04 PaulHarvey wysiwyg editor showing fault
Sandbox_-_edit_wysiwyg_hacked_-_Foswiki_-_Iceweasel_3.0.6.pngpng Sandbox_-_edit_wysiwyg_hacked_-_Foswiki_-_Iceweasel_3.0.6.png manage 88 K 31 Aug 2009 - 10:05 PaulHarvey wysiwyg editor showing hacked css without fault
natskin4759_styleurl.diffdiff natskin4759_styleurl.diff manage 1 K 03 Sep 2009 - 11:43 PaulHarvey fix rendering of NATSTYLEURL, use URLPATH instead of PATH smile
natskin4929_tmce-css.diffdiff natskin4929_tmce-css.diff manage 1 K 15 Sep 2009 - 06:05 PaulHarvey fix TinyMCE table related problems in css
Topic revision: r15 - 15 Sep 2009, PaulHarvey
The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. See Copyright Statement. Creative Commons License    Legal Imprint    Privacy Policy