Priority: Normal
Current State: Closed
Released In: n/a
Target Release: n/a
initial checkin
Thanks
MichaelDaum for this very interesting plugin.
TODO:
- Documentation
- NatSkin permissions tab
--
PaulHarvey - 27 Oct 2009
I had a couple of problems, but they are solved with the most recent version in SVN and this documentation:
* #Set SKIN = metacomment,pattern
* #Set DISPLAYCOMMENTS = on/off
* #Set COMMENTFORMAT = linear, threaded or reverse
* #Set COMMENTSTATE = on/off
* #Set COMMENTAPPROVAL = on/off
* #Set ALLOWCOMMENT =
* #Set ALLOWAPPROVAL =
the skin setting adds the comment layer
displaycomments switches on/off all of the commenting system
defaults to off
commentformat is the layout of the comments in the given styles
commentstate on means: commenting is allowed, off discussion closed yet still displayed but without the add comment box
allowcomment is an access list of people allowed to comment
allowapproval is the access list of people allowed to approve comments
commentapproval = on switches on the approval workflow: only approved comments are displayed
Then there are 2 missing
foswikiFormStep
tags missing in
metacomments.tmpl
, see attached patch.
--
ArthurClemens - 21 Dec 2010
Hm, no. Headings aren't valid form steps in their own. I'd prefer to fix the
PatternSkin css to render them appropriately.
--
MichaelDaum - 21 Dec 2010
Perhaps a padding plus a negative margin to
foswikiFormStep
would work.
Firefox Mac bails out with "too much recursion":
jquery-1.3.2.js (line 12)
.
--
ArthurClemens - 21 Dec 2010
"too much recursion" - thats "normal" still running jquery-1.3.2 together with the latest jquery-ui. These are incompatible.
Infact, I am expecting to see more people reporting exactly this issue when upgrading their foswiki. We will need to add some
provisions to delete the old jquery-1.3.2 and switch their
LoclalSite.cfg
to jquery-1.4.3 automatically
--
MichaelDaum - 22 Dec 2010
OK, so I need to check in configure which version is used.
Headings aren't valid form steps in their own - actually, why is the header inside
foswikiFormSteps
?
--
ArthurClemens - 22 Dec 2010
The foswikiFormSteps is the complete wrapper for the form section. The title is part of it. That's why it is inside as well.
Sometimes a form is made up of several logical sections. While
all of the form is in one foswikiFormSteps div, separate sections
deserve a title for each. So we will also end up with a h2 inside foswikiFormSteps2.
--
MichaelDaum - 23 Dec 2010
I have recoded the
foswikiFormSteps
styles, so text can be placed outside of
foswikiFormStep
.
--
ArthurClemens - 28 Dec 2010
Seems fine now even on
PatternSkin.
--
MichaelDaum - 25 Mar 2011