Item2342: the search cgi script is broken in trunk, and pretty pointless in 1.0
Priority: Normal
Current State: Closed
Released In: 1.1.0
Target Release: minor
Applies To: Engine
Component:
Branches:
looking at the code, there's no net benefit to the
search
cgi in 1.0.x - the progressive chunking of results has been disabled as it doesn't work for table formats, and it doesn't do html size header info
and in trunk it was broken months ago, by changes to the engine->param() call, and by the use of a non-topic baseWebObject - I noticed because i was looking for unit tests for that code - and they don't exist.
i
think we should deprecate the
search
cgi by making the Foswiki::UI::Search function call
view
and show the appropriate
WebSearch topic.
if not - someone needs to make tests for it.
additionally :/ the refactoring done to pass TOM objects has broken the non-=inline= Search::WebSearch (used by the
search
cgi) - again, no tests..
--
SvenDowideit - 09 Nov 2009
commited the needed fix, but i still think we should consider getting rid of it.
--
SvenDowideit - 09 Nov 2009
Fixing the switchboard test so they all use captureWithKey so save and upload pass too.
Also changed the CRLF parsing of HTTP headers. We need some small Func to do it, don't we?
--
OlivierRaginel - 11 Nov 2009