Item2434: BASE windowtitle

entry BASE%WEB% causes error in windowtitle

Line 25 in foswiki.tmpl:

BASE%WEB% changes %BASEWEB%

%TMPL:DEF{"windowtitle"}%<title>%TMPL:P{"titleaction"}% <nop>%BASETOPIC%%TMPL:P{"titlesep"}%BASE%WEB%%TMPL:P{"titlesep"}%<nop>%WIKITOOLNAME%</title>%TMPL:END%

-- CarlinhosCecconi

Ouch. Blame Sven...

Set to Urgent.

-- ArthurClemens - 30 Nov 2009

For people seeing this defect I will attach a corrected template file so you can easily fix this.

In templates replace the foswiki.tmpl file with the attached

http://365847.689093.cn/pub/Tasks/Item2434/foswiki.tmpl

The bug is in line 25 where %BASE%WEB% must be corrected to %BASEWEB%

-- KennethLavrsen - 30 Nov 2009

Am I missing something here as it looks like the fix isn't quite correct - I think it should be

%TMPL:DEF{"windowtitle"}%<title>%TMPL:P{"titleaction"}% <nop>%BASETOPIC%%TMPL:P{"titlesep"}%%BASEWEB%%TMPL:P{"titlesep"}%<nop>%WIKITOOLNAME%</title>%TMPL:END%

rather than

%TMPL:DEF{"windowtitle"}%<title>%TMPL:P{"titleaction"}% <nop>%BASETOPIC%%TMPL:P{"titlesep"}%BASEWEB%%TMPL:P{"titlesep"}%<nop>%WIKITOOLNAME%</title>%TMPL:END%

as the closing % of the preceding TMPL isn't present - I think the original % in BASEWEB was in the wrong place rather than superfluous.

-- MartinRowe - 30 Nov 2009

Yes. I had not fixed it correctly. I have fixed the fix.

-- KennethLavrsen - 30 Nov 2009