Priority: Normal
Current State: Closed
Released In:
Target Release: minor
Applies To: Extension
Component: Configure
Branches:
- Checkout trunk
- cd trunk/core/
- ./pseudo install default
- ./pseudo install developer
- Visit /bin/configure. 10 items are marked with a warning (guessed defaults).
- Settings have changed because defaults have been populated automatically; but somehow the javascript that enables the save button has not fired, because from its point of view the user hasn't changed anything.
- Unable to save
Expected behaviour:
- As on the release branch, I expected to be able to save the default settings that were guessed for me.
To confirm that there was nothing else wrong with my setup, I made the change in
templates/main.tmpl
(attached), after which configure allowed me to save.
I then reverted the change, and am able to continue to use configure normally.
Update: Running Debian Lenny w/Apache 2.2.9
--
PaulHarvey - 05 Dec 2009
A quick way to test this is by temporarily moving your
LocalSite.cfg
.
Indeed, when you start you should be able to just go ahead with the prefilled options.
The bug is caused by the recently added javascript.
What bugs me is that the submit button is disabled if you have javascript off, so there is no fallback.
And the changes introduce ugly direct calls from interface elements, while we solve all other javascript using css selectors.
--
ArthurClemens - 05 Dec 2009
I suggest to remove the disabled state of the submit button as it can create the annoying situation:
- you made some changes
- reload the page
- the browser remembers all settings, but javascript re-initializes, thereby disabling the submit button: what to do now?
With a working submit button no harm is done: if you haven't made any changs, you land on a page that says so.
We can enable/disable the Save button when we can do an AJAX call with a real check.
The alert text next to the "Other extensions" is ok, no harm there.
--
ArthurClemens - 05 Dec 2009