Editing certain topic is now impossible.

I get

TWiki detected an internal error - please check your TWiki logs and webserver logs for more information.

Undefined subroutine &TWiki::Contrib::JSCalendarContrib::renderFormFieldForEditHandler called

I cannot paste the actual topic because it contains confidencial info.

Will try to produce a generic test case.

-- KJL

Phew. It is the EditTablerowPlugin which is installed but not used in the topic.

[Fri Jan 19 19:09:30 2007] [error] [client 145.18.1.119] Undefined subroutine &TWiki::Contrib::JSCalendarContrib::renderFormFieldForEditHandler called at /var/www/twiki/lib/TWiki/Plugins/EditTablerowPlugin.pm line 803., referer: http://ehc.comm.mot.com/twiki/bin/view/Station/StatusReportRobin2Expansion?sortcol=1;table=1;up=0
[Fri Jan 19 19:09:30 2007] [error] [client 145.18.1.119]  at /var/www/twiki/lib/TWiki/Plugins/EditTablerowPlugin.pm line 803, referer: http://ehc.comm.mot.com/twiki/bin/view/Station/StatusReportRobin2Expansion?sortcol=1;table=1;up=0
[Fri Jan 19 19:09:30 2007] [error] [client 145.18.1.119] \tTWiki::Plugins::EditTablerowPlugin::renderFormFieldForEditHandler('TopicTitle', 'text', 70, 'Status Report Robin/Little John 2.0 - Expansion Cabinet', '', '') called at /var/www/twiki/lib/TWiki/Plugin.pm line 245, referer: http://ehc.comm.mot.com/twiki/bin/view/Station/StatusReportRobin2Expansion?sortcol=1;table=1;up=0
[Fri Jan 19 19:09:30 2007] [error] [client 145.18.1.119] \tTWiki::Plugin::invoke('TWiki::Plugin=HASH(0xa28a9a4)', 'renderFormFieldForEditHandler', 'TopicTitle', 'text', 70, 'Status Report Robin/Little John 2.0 - Expansion Cabinet', '', '') called at /var/www/twiki/lib/TWiki/Plugins.pm line 333, referer: http://ehc.comm.mot.com/twiki/bin/view/Station/StatusReportRobin2Expansion?sortcol=1;table=1;up=0

---

Looks like you might have an old version of the JSCaclendarContrib installed.

Awaiting your testcase with interest.

CC

To be honest I had given up this plugin at the office after upgrading to 4.1.2 because along these upgrades the plugin did not work at all. And then I forgot about this bug item. Sorry about that.

I will see if I can make a working test of it at home

KJL

Bug is still there.

What is required to reproduce is.

Make a topic.

Add a form to the topic.

Enable EditTablerowPlugin.

Try and edit your topic.

The plugin simply fails the minute you have a topic with a form.

I am not at all using the plugin on the topic.

I attach my test topic and my form to this bug report.

The error is seen on MAIN as of 18 Jun 2007

It is the EditTablerowPlugin line 801-803 that calls a non-API function directly from JsCalendarConrtib. And the function called is no longer there.

I am not sure that this is supposed to do. There are only 3 functions in the entire JSCalendarContrib: addHead, renderForEdit, renderDateForEdit. I cannot say if it is one of those that has to be called instead.

I will not look further into resolving this. I will leave this to Thomas Weigert. I will say this to potential users of this plugin and other plugins. Do not use plugins that uses non-API function calls for mission critical features because each time you upgrade TWiki you will run into problems like this. And to plugin authors. Please use API calls. And if the code is missing please copy the code to your plugin instead.

-- TWiki:Main.KennethLavrsen - 18 Jun 2007