Item3982: Add support for RevCommentPlugin and HistoryPlugin to NatSkin

pencil
Priority: Enhancement
Current State: No Action Required
Released In: n/a
Target Release: n/a
Applies To: Extension
Component: NatSkin
Branches:
Reported By: MichaelDaum
Waiting For:
Last Change By: MichaelDaum
These plugins need explicit treatment in a skin.

-- MichaelDaum - 27 Apr 2007

NatSkin-v3.0-pre17 has got support for the HistoryPlugin now. RevCommentPlugin pending.

-- MichaelDaum - 13 Nov 2007

I will not add support for RevCommentPlugin. That's too weak of a plugin in terms of quality. This plugin should be obsoleted by storing rev comments in the store and not in META variables. Btw the way rev comments are stored into META is designed rather badly.

-- MichaelDaum - 25 Mar 2011

I had a client that demanded this feature be supported so I investigated what would be involved. I figured out how to make it work and thought I'd document it here in case someone else needs it.

What we want to do is to create a customized version of the edittoolbar.natedit.tmpl file. If you modify the original, you risk having it over-written the next time you upgrade NatEditPlugin. Better to create it under your own skin. You can do this by simply duplicating that file and call it something like edittoolbar.myskin.tmpl. In your new file, insert a new line after the first line (that has "<div class="natEditBottomBar">") and add the following code (copied from PatternSkin):
%IF{ "context RevCommentPluginEnabled" then="<div class='revComment'><label for='comment'>Summary of changes</label> <input class='foswikiInputField' type='text' style='width:50%' name='comment' id='comment' /> %POPUPWINDOW{"%SYSTEMWEB%.RevComment" label="%MAKETEXT{"help"}%"}%</div>" else=""}%

To enable your new skin, add your new skin name to beginning of SKIN preference setting in Main.SitePreferences, like this:
   * Set SKIN = myskin,nat

The revision comment field will now be displayed right above the edit actions.

-- LynnwoodBrown - 16 Jul 2013

I am not happy with the way this has been dealt with frown, sad smile

-- Main.KennethLavrsen - 13 Aug 2015 - 18:49

While you're adding support for viewing/editing comments of the RevCommentPlugin you could add support for the sidebyside render mode of the CompareRevisionsAddOn as well Micha. wink

-- Main.FranzJosefGigler - 13 Aug 2015 - 19:51

Feel free to reopen this task and add a patch to a git branch for this item, Franz, or anybody else.

-- MichaelDaum - 13 Aug 2015
 

ItemTemplate edit

Summary Add support for RevCommentPlugin and HistoryPlugin to NatSkin
ReportedBy MichaelDaum
Codebase
SVN Range TWiki-4.1.2, Fri, 27 Apr 2007, build 13539
AppliesTo Extension
Component NatSkin
Priority Enhancement
CurrentState No Action Required
WaitingFor
Checkins TWikirev:15135 TWikirev:15136 TWikirev:15137
TargetRelease n/a
ReleasedIn n/a
CheckinsOnBranches
trunkCheckins
masterCheckins
ItemBranchCheckins
Release01x01Checkins
Topic revision: r13 - 13 Aug 2015, MichaelDaum
The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. See Copyright Statement. Creative Commons License    Legal Imprint    Privacy Policy