Item5406: Don't let a skin update break existing left bars and top bar
Priority: Urgent
Current State: Closed
Released In: 1.0.0
Target Release: patch
Pattern skin updates have been a pain in the past. Don't let a bug fix release rub the salt. I propose to change left bars of current webs to
WebLeftBarExample
and
WebTopBar
to
WebTopBarExample
. Only the _default web can have
WebLeftBar.
Of course there are complications I have overseen right now...
--
TWiki:Main/ArthurClemens - 01 Mar 2008
This bug should have been in the release blocker
SEARCH but whoever changed the release blockers topic forgot to add StandardReleaseComponent to quite many extensions incl Pattern Skin so it was missed.
If we do not ship
WebLeftBar with TWiki the existing webs will look like shit after an installation so the proposal as given is not going to work.
I agree that a solution for upgraders would be good. But the proposed solution is creating a new problem.
I will not let this block a 4.2.1 release. We can manually remove updates to
WebLeftBar from the upgrade package (as I have often done).
Lowering to Normal
--
KennethLavrsen - 02 Jun 2008
The templates that read WebTopBar, WebLeftbar and WebBottomBar now have this conditional (example left bar):
%IF{
"istopic 'WebLeftBar'"
then="$percntINCLUDE{$quot%WEB%.WebLeftBar$quot}$percnt"
else="$percntINCLUDE{$quot%WEB%.WebLeftBarExample$quot}$percnt"
}%
Meaning that WebLeftBarExample is read unless WebLeftBar exists.
This needs to be documented so that if users customize the side/top/bottom bars, they actually should create WebLeftBar/!WebTopbar/!WebBottomBar topics.
--
ArthurClemens - 03 Dec 2008
Elevating this to urgent
The relevant work missing is one section in the installation document.
I am going to give this a go tomorrow 24th so I assign the completion of this to myself
Documentation added to both install, upgrade and skin documentation.
Great new feature which is now documented also.