Item8987: TOPICLIST does not work on webs with NOSEARCHALL set

pencil
Priority: Normal
Current State: Closed
Released In: 1.1.0
Target Release: minor
Applies To: Engine
Component:
Branches:
Reported By: ColasNahaboo
Waiting For:
Last Change By: KennethLavrsen
%TOPICLIST{"..." web="XXX"}% does nothing on webs where NOSEARCHALL is set

This is not the correct behavior, as this is not a search-in-all-webs operation, but one targetting a single web. This bug was already there in TWiki 4.0.

The fix is quite simple, suppressing the 3 lines at lib/Foswiki.pm in function TOPICLIST (line 3930)
    return ''
      if $web ne $this->{webName}
          && $this->{prefs}->getWebPreferencesValue( 'NOSEARCHALL', $web );

I will commit the fix if no objection is raised

-- ColasNahaboo - 06 May 2010

That would be too sweeping a change; there may be apps depending on this legacy behaviour. So instead, if a web is explicitly named, don't check NOSEARCHALL.

-- CrawfordCurrie - 13 Jun 2010

 

ItemTemplate edit

Summary TOPICLIST does not work on webs with NOSEARCHALL set
ReportedBy ColasNahaboo
Codebase trunk
SVN Range
AppliesTo Engine
Component
Priority Normal
CurrentState Closed
WaitingFor
Checkins distro:94ed50f53230
TargetRelease minor
ReleasedIn 1.1.0
Topic revision: r6 - 04 Oct 2010, KennethLavrsen
The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. See Copyright Statement. Creative Commons License    Legal Imprint    Privacy Policy