You are here: Foswiki>Tasks Web>Item9619 (06 Sep 2010, ArthurClemens)Edit Attach

Item9619: rdiff sequential topic history view broken on trunk

Priority: Urgent
Current State: Closed
Released In: 1.1.0
Target Release: minor

Applies To: Engine
Component: rdiff PatternSkin
Branches:

Reported By: MichaelTempest
Waiting For:
Last Change By: ArthurClemens

The sequential topic history from rdiff is broken on trunk. The revision number and username of the person who made the change are not shown. For example, here is an extract from http://trunk.foswiki.org/bin/rdiff/Tasks/ItemTemplate?type=history showing the start of a revision's changes.

For comparison, here is a similar portion from 1.0.9:

-- MichaelTempest - 04 Sep 2010

It seems the rdiff feature was totally forgotten when the search templates got redesigned.

rdiff.pattern.tmpl refers to a %TMPL:INCLUDE{"searchbase"}% but this was removed already back in March. Many have since edited rdiff code but it seems noone has ever looked at the rdiff in a browser since.

Another basic UI that is not working at all.

Basic UI must work before we can release even a beta. We cannot release something where cliking on basic UI links ends up in broken screens.

-- KennethLavrsen - 05 Sep 2010

ItemTemplate edit

Summary	rdiff sequential topic history view broken on trunk
ReportedBy	MichaelTempest
Codebase	trunk
SVN Range
AppliesTo	Engine
Component	rdiff PatternSkin
Priority	Urgent
CurrentState	Closed
WaitingFor
Checkins	distro:48d03c56f997 distro:327e67b283b6 distro:7036ec8aab01
TargetRelease	minor
ReleasedIn	1.1.0

I	Attachment	Action	Size	Date	Who	Comment
PNG	109_history_diff.PNG	manage	8 K	04 Sep 2010 - 08:24	MichaelTempest	A reference image from 1.0.9
PNG	broken_history_diff.PNG	manage	5 K	04 Sep 2010 - 08:20	MichaelTempest	From the middle of a topic's history - which revision has this change, and who made that change?