You are here: Foswiki>Tasks Web>Item9631 (17 Sep 2010, ArthurClemens)Edit Attach

Item9631: Slideshow pages are too small

pencil
Priority: Urgent
Current State: Closed
Released In: 1.1.0
Target Release: minor
Applies To: Extension
Component: SlideShowPlugin
Branches:
Reported By: ArthurClemens
Waiting For:
Last Change By: ArthurClemens
something is wrong with the css.

-- ArthurClemens - 06 Sep 2010

Raising to urgent, as this is unusable.

-- ArthurClemens - 07 Sep 2010

Confirmed. There is no space at all below a slide and the next slide.

The original plugin added a lot of white space below. That could be the fix again if nothing else can be done quickly.

-- KennethLavrsen - 12 Sep 2010

The code to add is
$text .= "%BR%\n\n" x 20;
that was removed since 1.0.9

But we also have a problem with the skin. It has the same whitespace as the left bar which also makes the plugin useless.

I am very close to just reapply the 1.0.9 version of the plugin again for 1.1.0 so we can release.

-- KennethLavrsen - 12 Sep 2010

I am doing the following.

  • Changing the code to again emit the 20 empty lines. Ugly but it works. Revert when one of you have a better way
  • The height of each slide is defined in the slide template by defining the height of an image called clearpixel.gif. But someone changed the slide template to not include this image and goofed the height. So we restore it back to the way it was. Again. If someone wants a smarter way, go ahead but right now I am fine with just having something that WORKS
  • Finally the space in the left side is because someone changed from using skin to cover. And the cover does not cancel the default Pattern css. I am changing this back to skin.

-- KennethLavrsen - 12 Sep 2010

Whoever changed the default template also decided not to have any nice header on the slides. So instead of being a great example of how the plugin works, it is showing a minimalistic ugly thing.

I am restoring the nice looking header back. That is what the whole plugin is about!! Making a nice Powerpoint look-alike presentation. That is what business people want

-- KennethLavrsen - 12 Sep 2010

Arthur said in another bug item that he would not work further on this plugin.

So I close this with the checkin I did today that fixed the problem with a non-CSS solution

-- KennethLavrsen - 12 Sep 2010

Continued in Item9705.

-- ArthurClemens - 17 Sep 2010
 

ItemTemplate edit

Summary Slideshow pages are too small
ReportedBy ArthurClemens
Codebase 1.1.0 beta1, trunk
SVN Range
AppliesTo Extension
Component SlideShowPlugin
Priority Urgent
CurrentState Closed
WaitingFor
Checkins distro:c8ceba30a836 distro:ceea51b11a82
TargetRelease minor
ReleasedIn 1.1.0
Topic revision: r9 - 17 Sep 2010, ArthurClemens
The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. See Copyright Statement. Creative Commons License    Legal Imprint    Privacy Policy