You are here: Foswiki>Tasks Web>Item9709 (19 Sep 2010, GeorgeClark)Edit Attach

Item9709: MAKETEXT mistake in FAQWhyYouAreAskedToConfirm.txt (non-escaped ")

pencil
Priority: Urgent
Current State: Closed
Released In: 1.1.0
Target Release: minor
Applies To: Engine
Component: FAQWhyYouAreAskedToConfirm.txt
Branches:
Reported By: RaulFRodriguez
Waiting For:
Last Change By: GeorgeClark
While translating the strings in French, I came across an error in line 10 of the file in /core/data/System/FAQWhyYouAreAskedToConfirm.txt

The line mentions:

<div id="expl4"><p class="expl">%MAKETEXT{"The checks performed by Foswiki can sometimes be triggered when you do something perfectly innocent, for instance if you click the Back button after saving a page. Foswiki then uses the approach "better safe than sorry"."}%</p></div>

The two " in the expression "better safe than sorry" should be escaped, like that, otherwise the string is truncated to "uses the appoach ".

So the correct line is:

<div id="expl4"><p class="expl">%MAKETEXT{"The checks performed by Foswiki can sometimes be triggered when you do something perfectly innocent, for instance if you click the Back button after saving a page. Foswiki then uses the approach \"better safe than sorry\"."}%</p></div>

This change needs to be applied in :

  • /branches/Release01x01/core/data/System/FAQWhyYouAreAskedToConfirm.txt
  • /trunk/core/data/System/FAQWhyYouAreAskedToConfirm.txt

I am correcting this in SVN.

After this change is done, the strings for translation have to be generated again.

I am setting this to "Urgent" priority, since it impacts the translations which are due to be finalised very soon.

-- RaulFRodriguez - 18 Sep 2010

I checked-in the changes to SVN in distro:970d9d892d3d and distro:35b5ee21761d.

André, can you generate a new Foswiki.pot file and merge the strings with the languages .po files ?

-- RaulFRodriguez - 18 Sep 2010

Checked in now.

-- AndreUlrich - 19 Sep 2010

Two more mistakes.

text 1, original: "Wiki administrators should read about the "

text 1, new version: "Wiki administrators should read about the %1."

text 2, original: "For more detailed information on cross-site request forgery, and the dangers it poses to you, see "

text 2, new version: "For more detailed information on cross-site request forgery, and the dangers it poses to you, see the Cross-site request forgery article on Wikipedia."

-- ArthurClemens - 19 Sep 2010

Thanks Arthur. when I created the topic I asked around a bit for feedback - seeing as I didn't really know what I was doing with MAKETEXT. I guess that has now been proven.

-- GeorgeClark - 19 Sep 2010
 
Topic revision: r12 - 19 Sep 2010, GeorgeClark
The copyright of the content on this website is held by the contributing authors, except where stated elsewhere. See Copyright Statement. Creative Commons License    Legal Imprint    Privacy Policy