Item5804: can kill the new trunk code by appending odd url params.

for example:

http://develop.twiki.org/~twiki4/cgi-bin/view/Bugs?as

gets you:

Software error:

Use of uninitialized value in substitution (s///) at /home/twiki4/twikisvn/core/lib/TWiki.pm line 2401.

For help, please send mail to the webmaster (root@localhost), giving this error message and the time and date of the error.
Software error:

[Tue Jul 22 04:19:46 2008] view: Use of uninitialized value in substitution (s///) at /home/twiki4/twikisvn/core/lib/TWiki.pm line 2401.
 at /usr/lib/perl5/5.8.5/CGI/Carp.pm line 314
   CGI::Carp::realdie('[Tue Jul 22 04:19:46 2008] view: Use of uninitialized value i...') called at /usr/lib/perl5/5.8.5/CGI/Carp.pm line 400
   CGI::Carp::die('Use of uninitialized value in substitution (s///) at /home/tw...') called at /home/twiki4/twikisvn/core/lib/TWiki.pm line 165
   TWiki::__ANON__('Use of uninitialized value in substitution (s///) at /home/tw...') called at /home/twiki4/twikisvn/core/lib/TWiki.pm line 2401
   TWiki::urlEncode('undef') called at /home/twiki4/twikisvn/core/lib/TWiki/Request.pm line 227
   TWiki::Request::queryString('TWiki::Request=HASH(0x9a8c90c)') called at /home/twiki4/twikisvn/core/lib/TWiki/Request.pm line 276
   TWiki::Request::url('TWiki::Request=HASH(0x9a8c90c)') called at /home/twiki4/twikisvn/core/lib/TWiki/LoginManager.pm line 286
   TWiki::LoginManager::loadSession('TWiki::LoginManager::ApacheLogin=HASH(0x9d48740)', 'undef') called at /home/twiki4/twikisvn/core/lib/TWiki/Users.pm line 110
   TWiki::Users::new('TWiki::Users', 'TWiki=HASH(0x97768d8)') called at /home/twiki4/twikisvn/core/lib/TWiki.pm line 1302
   TWiki::new('TWiki', 'undef', 'TWiki::Request=HASH(0x9a8c90c)', 'HASH(0x99571a4)') called at /home/twiki4/twikisvn/core/lib/TWiki/UI.pm line 169
   TWiki::UI::execute('TWiki::Request=HASH(0x9a8c90c)', 'CODE(0x9af6b30)', 'view', 1) called at /home/twiki4/twikisvn/core/lib/TWiki/UI.pm line 125
   TWiki::UI::handleRequest('TWiki::Request=HASH(0x9a8c90c)') called at /home/twiki4/twikisvn/core/lib/TWiki/Engine/CGI.pm line 48
   TWiki::Engine::CGI::run('TWiki::Engine::CGI=HASH(0x99b99c4)') called at view line 43

For help, please send mail to the webmaster (root@localhost), giving this error message and the time and date of the error. 

-- TWiki:Main/SvenDowideit - 22 Jul 2008

There is two places where this problem appears:

• TWiki::Request::queryString - could send undef value to TWiki::urlEncode
• TWiki::urlEncode - doesn't check if $text is defined

I think both "problems" could be fixed.

-- TWiki:Main.GilmarSantosJr - 22 Jul 2008

I've fixed only the first (that solved the issue reported). What about the second point?

-- TWiki:Main.GilmarSantosJr - 22 Jul 2008

IMO the fix is enough.

• GilmarSantosJr - 24 Nov 2008